Set workaround for playback position reset when switching to main player with content thumbnail#7852
Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom Feb 11, 2022
Conversation
AudricV
added
bug
Contributor
|
I tried it, but it doesn't work. I don't remember what was the case when I made that comment, but I found out that the right |
…yer with content thumbnail The workaround set before was not applied when switching to main player with content thumbnail from popup or background player. This commit fixes this by applying the workaround when switching to main player with content thumbnail from popup or background player.
AudricV
force-pushed
the
player-recovery-workaround-play-thumbnail
branch
from
d92c848 to
608e73e
Compare
Member
Author
|
Indeed, the
Thank you for looking to this! Are my last changes working (I used what you said) or not? |
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
Yes, it works as expected. |
TobiGr
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
The workaround set with #7668 was not applied when switching to main player with content thumbnail from popup or background player. This PR fixes this by applying the workaround when switching to main player with content thumbnail from popup or background player.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence